Temporarily revert use of core::ffi::CStr #509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The move of `CStr` from `std` to `core` is not due to become stable until 1.64. The first nightly where it could be used without the unstable `core_c_str` feature was 2022-07-16, which is still pretty recent. Let's back this change out for now to give users pinned to older versions more time.
|
Yeah, I see. It is very new. Should we add a |
|
Created follow-up ticket #510 |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The move of
CStrfromstdtocoreis not due to become stable until 1.64. The first nightly where it could be used without the unstablecore_c_strfeature was 2022-07-16, which is still pretty recent. Let's back this change out for now to give users pinned to older versions more time.Checklist
Rewriting History guide for
help.